fix: try variants in turn if fan is broadcasting without variant #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses scenarios in which the fan is broadcasting without a variant, and allows the grouped model option to try each variant in turn before declaring an error
|
I'm now using of 358K model, and this commit works very well. |
@nara1111 want to buy a PH05. Is this the 358K model you have, which works with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dotvezz,
My sincere apologies for introducing this bug into the configuration flow in v1.6.0.
This fix addresses scenarios in which a fan is broadcasting without a variant, allowing the grouped model option to try each variant in turn before declaring an error
Fixes #248
Fixes #263
Fixes #275