-
Notifications
You must be signed in to change notification settings - Fork 52
Windows DLL support #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laheller
wants to merge
1
commit into
liberfa:master
Choose a base branch
from
laheller:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Windows DLL support #107
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,256 @@ | ||
| VERSION 0.1 | ||
| EXPORTS | ||
| eraCal2jd | ||
| eraEpb | ||
| eraEpb2jd | ||
| eraEpj | ||
| eraEpj2jd | ||
| eraJd2cal | ||
| eraJdcalf | ||
| eraAb | ||
| eraApcg | ||
| eraApcg13 | ||
| eraApci | ||
| eraApci13 | ||
| eraApco | ||
| eraApco13 | ||
| eraApcs | ||
| eraApcs13 | ||
| eraAper | ||
| eraAper13 | ||
| eraApio | ||
| eraApio13 | ||
| eraAtcc13 | ||
| eraAtccq | ||
| eraAtci13 | ||
| eraAtciq | ||
| eraAtciqn | ||
| eraAtciqz | ||
| eraAtco13 | ||
| eraAtic13 | ||
| eraAticq | ||
| eraAticqn | ||
| eraAtio13 | ||
| eraAtioq | ||
| eraAtoc13 | ||
| eraAtoi13 | ||
| eraAtoiq | ||
| eraLd | ||
| eraLdn | ||
| eraLdsun | ||
| eraPmpx | ||
| eraPmsafe | ||
| eraPvtob | ||
| eraRefco | ||
| eraEpv00 | ||
| eraMoon98 | ||
| eraPlan94 | ||
| eraFad03 | ||
| eraFae03 | ||
| eraFaf03 | ||
| eraFaju03 | ||
| eraFal03 | ||
| eraFalp03 | ||
| eraFama03 | ||
| eraFame03 | ||
| eraFane03 | ||
| eraFaom03 | ||
| eraFapa03 | ||
| eraFasa03 | ||
| eraFaur03 | ||
| eraFave03 | ||
| eraBi00 | ||
| eraBp00 | ||
| eraBp06 | ||
| eraBpn2xy | ||
| eraC2i00a | ||
| eraC2i00b | ||
| eraC2i06a | ||
| eraC2ibpn | ||
| eraC2ixy | ||
| eraC2ixys | ||
| eraC2t00a | ||
| eraC2t00b | ||
| eraC2t06a | ||
| eraC2tcio | ||
| eraC2teqx | ||
| eraC2tpe | ||
| eraC2txy | ||
| eraEo06a | ||
| eraEors | ||
| eraFw2m | ||
| eraFw2xy | ||
| eraLtp | ||
| eraLtpb | ||
| eraLtpecl | ||
| eraLtpequ | ||
| eraNum00a | ||
| eraNum00b | ||
| eraNum06a | ||
| eraNumat | ||
| eraNut00a | ||
| eraNut00b | ||
| eraNut06a | ||
| eraNut80 | ||
| eraNutm80 | ||
| eraObl06 | ||
| eraObl80 | ||
| eraP06e | ||
| eraPb06 | ||
| eraPfw06 | ||
| eraPmat00 | ||
| eraPmat06 | ||
| eraPmat76 | ||
| eraPn00 | ||
| eraPn00a | ||
| eraPn00b | ||
| eraPn06 | ||
| eraPn06a | ||
| eraPnm00a | ||
| eraPnm00b | ||
| eraPnm06a | ||
| eraPnm80 | ||
| eraPom00 | ||
| eraPr00 | ||
| eraPrec76 | ||
| eraS00 | ||
| eraS00a | ||
| eraS00b | ||
| eraS06 | ||
| eraS06a | ||
| eraSp00 | ||
| eraXy06 | ||
| eraXys00a | ||
| eraXys00b | ||
| eraXys06a | ||
| eraEe00 | ||
| eraEe00a | ||
| eraEe00b | ||
| eraEe06a | ||
| eraEect00 | ||
| eraEqeq94 | ||
| eraEra00 | ||
| eraGmst00 | ||
| eraGmst06 | ||
| eraGmst82 | ||
| eraGst00a | ||
| eraGst00b | ||
| eraGst06 | ||
| eraGst06a | ||
| eraGst94 | ||
| eraPvstar | ||
| eraStarpv | ||
| eraFk425 | ||
| eraFk45z | ||
| eraFk524 | ||
| eraFk52h | ||
| eraFk54z | ||
| eraFk5hip | ||
| eraFk5hz | ||
| eraH2fk5 | ||
| eraHfk5z | ||
| eraStarpm | ||
| eraEceq06 | ||
| eraEcm06 | ||
| eraEqec06 | ||
| eraLteceq | ||
| eraLtecm | ||
| eraLteqec | ||
| eraG2icrs | ||
| eraIcrs2g | ||
| eraEform | ||
| eraGc2gd | ||
| eraGc2gde | ||
| eraGd2gc | ||
| eraGd2gce | ||
| eraD2dtf | ||
| eraDat | ||
| eraDtdb | ||
| eraDtf2d | ||
| eraTaitt | ||
| eraTaiut1 | ||
| eraTaiutc | ||
| eraTcbtdb | ||
| eraTcgtt | ||
| eraTdbtcb | ||
| eraTdbtt | ||
| eraTttai | ||
| eraTttcg | ||
| eraTttdb | ||
| eraTtut1 | ||
| eraUt1tai | ||
| eraUt1tt | ||
| eraUt1utc | ||
| eraUtctai | ||
| eraUtcut1 | ||
| eraAe2hd | ||
| eraHd2ae | ||
| eraHd2pa | ||
| eraTpors | ||
| eraTporv | ||
| eraTpsts | ||
| eraTpstv | ||
| eraTpxes | ||
| eraTpxev | ||
| eraA2af | ||
| eraA2tf | ||
| eraAf2a | ||
| eraAnp | ||
| eraAnpm | ||
| eraD2tf | ||
| eraTf2a | ||
| eraTf2d | ||
| eraRx | ||
| eraRy | ||
| eraRz | ||
| eraCp | ||
| eraCpv | ||
| eraCr | ||
| eraP2pv | ||
| eraPv2p | ||
| eraIr | ||
| eraZp | ||
| eraZpv | ||
| eraZr | ||
| eraRxr | ||
| eraTr | ||
| eraRxp | ||
| eraRxpv | ||
| eraTrxp | ||
| eraTrxpv | ||
| eraRm2v | ||
| eraRv2m | ||
| eraPap | ||
| eraPas | ||
| eraSepp | ||
| eraSeps | ||
| eraC2s | ||
| eraP2s | ||
| eraPv2s | ||
| eraS2c | ||
| eraS2p | ||
| eraS2pv | ||
| eraPdp | ||
| eraPm | ||
| eraPmp | ||
| eraPn | ||
| eraPpp | ||
| eraPpsp | ||
| eraPvdpv | ||
| eraPvm | ||
| eraPvmpv | ||
| eraPvppv | ||
| eraPvu | ||
| eraPvup | ||
| eraPvxpv | ||
| eraPxp | ||
| eraS2xpv | ||
| eraSxp | ||
| eraSxpv | ||
| eraVersion | ||
| eraVersionMajor | ||
| eraVersionMinor | ||
| eraVersionMicro | ||
| eraSofaVersion | ||
| eraGetLeapSeconds | ||
| eraSetLeapSeconds | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this version? Just of the
.deffile?As I mentioned, ideally this file is generated automatically. How did you create it? Might that be transferable? (If not, we can do this as follow-up.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhvk
This is just the DLL versioning, a kind of metadata that we can add to the final DLL during the build and it can be displayed using the
dumpbin /HEADERS erfa.dllcommand and has nothing to do with the erfa/sofa versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it match the soversion then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avalentino
If the soversion is defined somewhere, then yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is defined in
meson.build(andconfigure.ac, but let's not worry about that...):erfa/meson.build
Lines 10 to 20 in 1d9738b
I wonder if this file can be generated automatically by
meson(maybe with help of a script)...Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is what are you going to parse and what rules to apply. :) The header file? All symbols that have the word "erfa" in them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eli-schwartz - in our case I think
ls src/*.cbasically gives us what we need (strip.c, capitalize first character, and prefix withera). I think that should not be too difficult to do from meson (if just by calling out to some few-line script), but will admit my meson-fu is quite lacking (still too used tomake...).But I was asking mostly since @laheller presumably made this file one way or another, so perhaps he already used some handy one-liner. If not, I'll have a look myself, and push either to this PR or do a follow-up. If it turns out to be less easy than I think, I can always adjust the scripts that do the translation of sofa to erfa, at https://github.com/liberfa/erfa-fetch, to also create this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhvk
If you ask, how I made the DEF file:
I used the .NET version of the
libclanglibrary to parse theerfa.handerfaextra.hheaders to easily get the C function names (+ the whole signature needed for the C# wrapper).