Drop support for Python 3.9 #185
Conversation
| description = | ||
| run tests | ||
| devdeps: with the latest developer version of key dependencies | ||
| olddeps: with medium old versions of key dependencies |
There was a problem hiding this comment.
If there are concerns that the range of supported numpy versions is so wide that the devdeps and oldestdeps CI jobs are not enough then I suggest following the advice of SPEC 0 and limiting the range of supported versions.
| # The following provides some specific pinnings for key packages | ||
| deps = | ||
| oldestdeps: numpy==1.19.* # astropy LTS | ||
| olddeps: numpy==1.20.* # something potentially problematic (see gh-101) |
There was a problem hiding this comment.
I couldn't find any useful details in #101.
eerovaher
force-pushed
the
drop-np-lt-1.21
branch
from
cecd071 to
ca5b5e9
Compare
|
coincidentally, numpy 1.21.2 was the first version to support Python 3.10, and with 3.9 now being officially EOL, I think we could very much consider dropping 3.9 and requiring numpy>=1.21.2 in the same PR |
|
I thought the idea of dropping support for Python 3.9 was a good one and I would have been willing to implement it, but because this PR got approved as it is then I'll refrain from updating it. |
|
@eerovaher please feel free to go on with 3.9 removal and request a new approval when you have finished |
eerovaher
force-pushed
the
drop-np-lt-1.21
branch
3 times, most recently
from
e1eae4e to
7fba65b
Compare
|
I've updated this PR to drop support for Python 3.9. SPEC 0 allows dropping support for Python 3.11 and |
eerovaher
force-pushed
the
drop-np-lt-1.21
branch
from
7fba65b to
9375ee0
Compare
| if self.name == 'zpv': | ||
| # Works on newer numpy | ||
| return "np.__version__ < '1.21', reason='needs numpy >= 1.21'" |
There was a problem hiding this comment.
I didn't notice this earlier, but we don't have to worry about numpy < 1.21 anymore.
The oldest supported version of `numpy` has been updated accordingly.
eerovaher
force-pushed
the
drop-np-lt-1.21
branch
from
9375ee0 to
ac6cd21
Compare
|
Sorry @eerovaher , is this ready to me verged now? |
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Yes, happy to upgrade. It is just that there hasn't been a new SOFA for a long time that there seemed to be no reason to upgrade python/numpy either.
|
Actually, sorry, would be good to add an entry in |
|
There aren't any minimum supported Python or Line 60 in 967d163 |
|
Seems like a good opportunity to start documenting these |
|
I agree we should be better, but am fine with not doing it now, but rather at the release. Let me just merge this. |
4 participants
I would like to add type annotations to
astropy.coordinates, and becausepyerfais a very important dependency then having type annotations inpyerfawould help a lot. Currentlypyerfasupportsnumpy>=1.19.3, which is a problem for type annotations becausenumpy.typingwasn't introduced until 1.20 andnumpy.typing.NDArraywasn't introduced until 1.21. This also came up in #176.numpy1.21 was released in 2021, so this complies with SPEC 0.UPDATE: Given that Python 3.9 has reached end-of-life, it is a good idea to start requiring Python >= 3.10. The oldest version of
numpythat supports Python 3.10 is 1.21.3, so thenumpyrequirement has been updated accordingly. (numpy1.21.2 provided wheels for Python 3.10rc1, but does not claim to support Python 3.10).