Refactor DNA Matching Job and Clean Up Redundant Code#1126
Merged
curtisdelicata merged 1 commit intomainfrom Apr 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by Sweep to resolve the following request by @curtisdelicata:
Continue chatting at https://app.sweep.dev/c/b61243dc-08ba-4718-8e05-8b4c5f94d1d9.
Purpose
The purpose of this pull request is to enhance the maintainability and performance of the DNA matching job by removing redundant code and ensuring that the application adheres to best practices. This will help prevent potential issues related to unnecessary processing and improve the overall clarity of the codebase.
Description
This pull request primarily focuses on the
DnaMatchingjob within the application. The changes include the removal of redundant calls tojson_decode, which were previously commented out but left in the code. This cleanup not only simplifies the code but also reduces the risk of confusion for future developers. Additionally, minor adjustments were made across various files to ensure consistency and maintainability.Summary
json_decodecalls inapp/Jobs/DnaMatching.phpto streamline the code.Affected Files
app/Jobs/DnaMatching.phpapp/Jobs/ImportGedcom.phpapp/Http/Livewire/EnsureLivewireComponentsAreRegistered.phpapp/Filament/App/Resources/SourceRefEvenResource.phpresources/views/components/action-message.blade.phpapp/Filament/App/Resources/SourceRefEvenResource/Pages/CreateSourceRefEven.phpapp/Filament/App/Resources/SourceRefEvenResource/Pages/EditSourceRefEven.phppublic/index.phpapp/Filament/App/Resources/SourceDataEvenResource/Pages/EditSourceDataEven.phpapp/Filament/App/Resources/SourceDataEvenResource.phptests/Filament/Resources/AddrResourceTest.phptests/Feature/Filament/Resources/NoteResourceTest.phptests/Filament/Resources/SourceRefEvenResourceTest.phptests/Filament/Resources/DnaResourceTest.phptests/Filament/Resources/DnaMatchingResourceTest.php