Optimize Service Provider Bindings to Prevent Circular Dependencies#1157
Merged
curtisdelicata merged 1 commit intomainfrom May 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by Sweep to resolve the following request by @curtisdelicata:
Continue chatting at https://app.sweep.dev/c/f6d1a08d-13fa-442a-b234-b3b5de400b85.
Purpose
This pull request enhances the dependency injection system in the
TeamServiceProviderby implementing lazy loading through callbacks to prevent circular dependencies and improve application bootstrapping.Description
The changes modify how service bindings are registered in the
TeamServiceProviderclass. Instead of direct class bindings, the implementation now uses callback functions to create instances of various models and utilities. This approach:The modification affects multiple model bindings including Family, Person, Events, and related models used in the genealogy system.
Summary
TeamServiceProvider.phpto implement lazy loading through callbacksBatchDataFamilyand related models (FamilyEvent,FamilySlgs)Personand related models (PersonAsso,PersonAlia,PersonEvent)Addr,Chan,Subm)