fix: resolve GEDCOM import errors for royal92.ged#1488
Open
osacorp wants to merge 1 commit intoliberu-genealogy:mainfrom
Open
fix: resolve GEDCOM import errors for royal92.ged#1488osacorp wants to merge 1 commit intoliberu-genealogy:mainfrom
osacorp wants to merge 1 commit intoliberu-genealogy:mainfrom
Conversation
- BatchData: rewrite as standalone class (vendor class is final, cannot extend) - Injects tenant team_id into all upserted records - Chunks inserts with error logging per chunk - composer.json: add cweagans/composer-patches with patch entries for liberu-genealogy/laravel-gedcom vendor fixes - patches/fix-parent-data-uid-empty-string.patch: Use ?: instead of ?? so empty-string UIDs get replaced with UUID - patches/fix-even-variable-collision.patch: Rename inner \ -> \ to avoid variable shadowing - patches/fix-family-data-gid-lookup.patch: Look up husband/wife by GEDCOM gid instead of uid; fix null dereference - patches/fix-fam-even-array-class-error.patch: Guard against non-object \ to prevent 'Cannot use ::class on array'
Contributor
Author
|
okay |
|
Interesting approach and I apricate the fix but patches are welcome upstream on liberu-genealogy/laravel-gedcom potentially dynamic approach to team or no team. I'm back Friday. All is well, Curtis. @osacorp |
|
@osacorp you could remove the final definition on upstream if required, happy with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchData: rewrite as standalone class (vendor class is final, cannot extend)
composer.json: add cweagans/composer-patches with patch entries for liberu-genealogy/laravel-gedcom vendor fixes
patches/fix-parent-data-uid-empty-string.patch: Use ?: instead of ?? so empty-string UIDs get replaced with UUID
patches/fix-even-variable-collision.patch: Rename inner \ -> \ to avoid variable shadowing
patches/fix-family-data-gid-lookup.patch: Look up husband/wife by GEDCOM gid instead of uid; fix null dereference
patches/fix-fam-even-array-class-error.patch: Guard against non-object \ to prevent 'Cannot use ::class on array'