Update gdx-pay-android-googlebilling to minSdk 21 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auraxangelic
approved these changes
Sep 9, 2025
Member
|
I understand we can do it, but is there any advantage for users of the library if we upgrade? |
Author
|
Practically speaking, honestly not sure. But given it will not work on < 21, there's no advantage to keeping it set to 14 either. |
Member
|
minSdk is now 24 by PR #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't follow this repository but I saw #274. We can update the minSdk since Google Play Billing itself requires it as per https://play.google.com/sdks/details/com-android-billingclient-billing. libGDX itself is on 21 now.
Separately, I'd recommend a developer reviews this to see if target can be bumped to 36:
gdx-pay/build.gradle
Lines 13 to 15 in bf4d166