Fix CMYK blending order: blend in CMYK space then convert to RGB #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix multi-layer CMYK image blending by deferring CMS conversion until after blending operations complete.
Problem: For CMYK images with alpha blending across multiple layers, blending in RGB space (after CMS conversion) produces incorrect results. The correct approach is to blend in CMYK space first, then convert to RGB.
Solution: Defer CMS conversion for CMYK images when:
save_before_ct=false)This ensures reference frames are saved in CMYK space so subsequent frames blend correctly before final CMS conversion.
Changes
jxl/src/frame/render.rs: Restructured CMS stage application to support deferred execution for CMYK blendingCredit
Based on the fix from @lilith in lilith/jxl-rs.