Skip to content

Conversation

@xiyang141
Copy link

PR受影响的平台

诱因和背景

PR描述
新武将寒冰剑少女,藤甲男孩

PR测试
本地测试

扩展适配

检查清单

  • 我没有把该PR提交到master分支
  • commit中没有无用信息,和没有具体内容的“bugfix”
  • 我已经进行了充足的测试,且现有的测试都已通过
  • 若我拥有PR标签权限,则已确保为该PR打上标签;若我未拥有PR标签权限且该PR仍需继续提交内容,则已确保为该PR名称打上WIP直到本PR内容全部提交
  • 如果此次PR中添加了新的武将,则我已在character/rank.js中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx的参数
  • 如果此次PR中添加了新的语音文件,则我已在lib.translate中加入语音文件的文字台词
  • 如果此次PR涉及到新功能的添加,我已在PR描述中写入详细文档
  • 如果此次PR需要扩展跟进,我已在扩展适配中写入详细文档
  • 如果这个PR解决了一个issue,我在诱因和背景中明确链接到该issue
  • 我保证该PR中没有随意修改换行符等内容,没有制造出大量的Diff
  • 我保证该PR遵循项目中.editorconfigeslint.config.mjsprettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码

@xjm0708 xjm0708 requested review from AstralBarrage and xizifu and removed request for xizifu November 10, 2025 02:36
Comment on lines 23 to 38
if (get.type2(card) == get.type2(cardx)) {
await player.gain(event.cards, "gain2");
num++;
}
if (get.suit(card) == get.suit(cardx)) {
await player.recover();
num++;
}
if (get.cardNameLength(card) == get.cardNameLength(cardx)) {
await player.draw(get.cardNameLength(card));
num++;
}
if (get.number(card) == get.number(cardx)) {
await trigger.target.loseHp(trigger.target.getHp());
num++;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个判断得加个false排除持有者影响

cardname(card, player, name) {
const suits = player.getStorage("yj_yanyu_fire"),
suit = get.suit(card);
if (!suits.includes(suit, false)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了个false

@xizifu xizifu merged commit a9a78b2 into libnoname:PR-Branch Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants