-
Notifications
You must be signed in to change notification settings - Fork 757
寒冰剑藤甲 #3103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
寒冰剑藤甲 #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstralBarrage
suggested changes
Nov 10, 2025
character/newjiang/skill.js
Outdated
Comment on lines
23
to
38
| if (get.type2(card) == get.type2(cardx)) { | ||
| await player.gain(event.cards, "gain2"); | ||
| num++; | ||
| } | ||
| if (get.suit(card) == get.suit(cardx)) { | ||
| await player.recover(); | ||
| num++; | ||
| } | ||
| if (get.cardNameLength(card) == get.cardNameLength(cardx)) { | ||
| await player.draw(get.cardNameLength(card)); | ||
| num++; | ||
| } | ||
| if (get.number(card) == get.number(cardx)) { | ||
| await trigger.target.loseHp(trigger.target.getHp()); | ||
| num++; | ||
| } |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这几个判断得加个false排除持有者影响
character/newjiang/skill.js
Outdated
| cardname(card, player, name) { | ||
| const suits = player.getStorage("yj_yanyu_fire"), | ||
| suit = get.suit(card); | ||
| if (!suits.includes(suit, false)) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多了个false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR受影响的平台
无
诱因和背景
无
PR描述
新武将寒冰剑少女,藤甲男孩
PR测试
本地测试
扩展适配
无
检查清单
master分支WIP直到本PR内容全部提交character/rank.js中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx的参数lib.translate中加入语音文件的文字台词PR描述中写入详细文档扩展适配中写入详细文档诱因和背景中明确链接到该issue.editorconfig、eslint.config.mjs和prettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码