Open
Conversation
vyzo
reviewed
Sep 19, 2025
Contributor
vyzo
left a comment
vyzo
left a comment
There was a problem hiding this comment.
we used to have that some years ago, and then we made one big happy monorepo.... I am not sure it is such a great idea to go back to separate core, there was quite a bit of pain and frustration.
I would definitely consult @raulk on this.
Collaborator
Author
|
The pain with the previous setup was the separate repo. This keeps this mono repo, which allows for atomic changes across modules. |
MarcoPolo
force-pushed
the
core-module
branch
8 times, most recently
from
b01a8e8 to
edaf585
Compare
sukunrt
approved these changes
Sep 25, 2025
Member
sukunrt
left a comment
sukunrt
left a comment
There was a problem hiding this comment.
The core separation seems fine to me. Users can depend on something small plus with the newbuilder they can depend on exactly what they want. The steps to roll this out, as I see it are:
- Separate the refactor changes.
- Do a go-libp2p release.
- Separate the core; Do a core release.
- Do a go-libp2p release which depends on the core release from 3.
This lets protocols, such as Gossipsub, to be more agnostic to the specific version of go-libp2p they are running on. Instead they depend only on a specific version of an interface. The core module should remain fairly stable. After some time we could consider cutting a v1 release. But for now it will follow a patch or match versioning. If it's a patch compatible change only the patch number will change, if not it will match the version of go-libp2p.
MarcoPolo
force-pushed
the
core-module
branch
from
edaf585 to
e73513e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets protocols, such as Gossipsub and Maybe Kad-DHT, to be more agnostic to the specific version of go-libp2p they are running on. Instead they depend only on a specific version of an interface.
The core module should remain fairly stable. After some time we could consider cutting a v1 release. But for now it will follow a patch or match versioning. If it’s a patch compatible change only the patch number will change, if not it will match the version of go-libp2p.