Closed
Conversation
…announce new opt-in libp2p.LoopbackAddrPublishing(bool) lets hosts exclude loopback addresses (127.0.0.0/8, ::1) from the peerstore self-entry and the signed peer record so they are not advertised via identify or DHT. default is true (current behavior preserved). when set to false the addrsManager strips loopback before SetAddrs and before signing the peer record; loopback-to-loopback dev still works because identify keeps loopback on loopback connections via its viaLoopback path. - options.go: add LoopbackAddrPublishing(enable bool) - config/config.go: add DisableLoopbackAddrPublishing, plumb to HostOpts - basic_host.go: add HostOpts.DisableLoopbackAddrPublishing, pass to newAddrsManager - addrs_manager.go: new disableLoopbackAddrPublishing field, splitPublishedAddrs helper, updatePeerStore filters loopback when enabled - addrs_manager_test.go: cover both default and disabled-publishing paths
lidel
changed the title
lidel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes new opt-in flags:
libp2p.LoopbackAddrPublishing(bool)that lets hosts exclude loopback addresses (127.0.0.0/8,::1) from the peerstore self-entry and the signed peer record so they are not advertised via identify or DHT.Note
Moved to #3489 which fixes wider issue and includes this.