feat: expose interface index for an address#51
Draft
elenaf9 wants to merge 2 commits intolibp2p:masterfrom
Draft
feat: expose interface index for an address#51elenaf9 wants to merge 2 commits intolibp2p:masterfrom
elenaf9 wants to merge 2 commits intolibp2p:masterfrom
Conversation
elenaf9
force-pushed
the
interface-index
branch
from
06fbbb5 to
ce7dd46
Compare
jxs
approved these changes
May 3, 2025
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Looks good to me Elena, thanks for looking into this!
as you referred we probably should test this on the mdns protocol before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add function
IfWatcher::get_if_indexon all platforms to query the interface index for a known address.The index is needed for libp2p/rust-libp2p#5783 when joining an ipv6 multicast group in mDNS with
UdpSocket::join_multicast_v6.Need to do some testing within rust-libp2p before merging this.