feat: allow overriding stream handlers #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `force` flag to `libp2p.handle` that means the method will not throw if a handler already exists for the protocol being handled. Fixes #2928
achingbrain
force-pushed
the
feat/allow-overriding-handlers
branch
from
1654573 to
06750d1
Compare
Merged
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Apr 28, 2025
…7755) **Motivation** Right now, we do [not register a handler if it already is already registered](https://github.com/ChainSafe/lodestar/blob/78a5e72989d10426b77bd408673fe191bbf33f8a/packages/reqresp/src/ReqResp.ts#L102-L105) but even though we update some parts now such as rate limit at the hard fork, we do not update all of them like `requestSizes`, we can either pass the fork down in all the code paths where it is needed and use getter functions or we override the handler once during the hard fork transition. This PR proposes the later solution as it's much simpler and seems cleaner as well. **Description** Override libp2p handler when registering protocol for new fork, this is possible now due to libp2p/js-libp2p#2945 since we updated to libp2p 2.0 in #7359. More context libp2p/js-libp2p#2928 Closes #7557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
forceflag tolibp2p.handlethat means the method will not throw if a handler already exists for the protocol being handled.Fixes #2928
Change checklist