Fix: Resolve DHT regression caused by race condition in stream muxer initialization#1147
Fix: Resolve DHT regression caused by race condition in stream muxer initialization#1147seetadev merged 14 commits intolibp2p:mainfrom
Conversation
|
@seetadev Please review this PR. |
|
@asmit27rai : please resolve CI/CD issues. Happy to review. CCing @sumanjeet0012 and @acul71 for their thoughts and feedback too. |
|
@asmit27rai Could you add a newsfragment file for this PR. |
|
@sumanjeet0012 Newsfragment added. |
|
@asmit27rai : Hi Asmit, great work on this fix 👏 This addresses a pretty critical regression in the DHT flow, and the root cause around the race condition in stream muxer initialization is well handled. Fixing the handshake failure with bootstrap peers is a big reliability win, especially since this impacts core connectivity. The changes are clean and focused, and it’s good to see CI passing and the newsfragment added as well. Overall, this looks like a solid and important fix that improves stability of the networking stack, nice job pushing this through. CCing @sumanjeet0012 for his review and feedback. We should land it in the coming release. |
|
@asmit27rai : There is just one CI/CD issue I noticed. Otherwise, ready for final review + merge. Thank you for the review: @sumanjeet0012 |
Fixes #1128 - DHT regression on v0.5.0 where streams fail to open to bootstrap peers with error "handshake write failed: fail to write to multiselect communicator".