feat(quic): properly unpack both ipv4 and ipv6 addresses#1236
Open
xpanvictor wants to merge 2 commits intolibp2p:mainfrom
Open
feat(quic): properly unpack both ipv4 and ipv6 addresses#1236xpanvictor wants to merge 2 commits intolibp2p:mainfrom
xpanvictor wants to merge 2 commits intolibp2p:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Issue #1232
The quic listener didn't properly unpack ipv6 addresses.
How was it fixed?
Socket.getsockname()returns(host, port)for IPv4 and(host, port, flowinfo, scope_id)for IPv6so I pick via indices directly hereby same solution for v4 and v6 addresses.
Summary of approach.
To-Do