fix: gossipsub-batch-subscription#6385
Open
Shashwat-Nautiyal wants to merge 1 commit intolibp2p:masterfrom
Open
fix: gossipsub-batch-subscription#6385Shashwat-Nautiyal wants to merge 1 commit intolibp2p:masterfrom
Shashwat-Nautiyal wants to merge 1 commit intolibp2p:masterfrom
Conversation
Shashwat-Nautiyal
force-pushed
the
fix/gossipsub-batch-subscription
branch
from
37ae246 to
40e6f3b
Compare
Shashwat-Nautiyal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when a new peer connected, the GossipSub behaviour sent one RpcOut::Subscribe message per subscribed topic. This meant N separate protobuf frames were written to the wire for N topics.
This PR introduces
RpcOut::SubscribeMany, a batched variant that carries all subscriptions as aVec<(TopicHash, bool, bool)>, and updateson_connection_establishedto use it. The result is a singleproto::RPCwith multiple SubOpts entries on the wire, which is both spec-compliant and more efficient.The receiving side was already correct as
handle_received_subscriptionsalready iterates aVec<proto::SubOpts>, so no changes are needed there and backward compatibility is fully preserved.Fixes #6271
Notes & open questions
Change checklist