feat: expose known errors input in run-transport-interop-test action#842
Merged
MarcoPolo merged 8 commits intolibp2p:masterfrom Mar 25, 2026
Merged
feat: expose known errors input in run-transport-interop-test action#842MarcoPolo merged 8 commits intolibp2p:masterfrom
MarcoPolo merged 8 commits intolibp2p:masterfrom
Conversation
This reverts commit ae02cb5.
1 task
Contributor
Author
|
Hi @MarcoPolo, can I ask you for a review? I see you worked on #839 |
MarcoPolo
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
known-errorsinput to the transport interop test action. This lets repos that use the action pass a regex of their own expected failures. The pattern gets merged withknownErrors.jsonif one exists, so both sources work together.Tested with: https://github.com/vacp2p/nim-libp2p/actions/runs/23485588939?pr=2185 (vacp2p/nim-libp2p#2185)