Skip to content

Raise target SDK to 33 for PdCore and PdTest #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

tkirshboim
Copy link
Member

@tkirshboim tkirshboim commented Jun 15, 2023

I tested PdTest on Android 28 and 33 emulators and was able to get audio input and output.

The other apps seem to no longer work as expected, probably because they are not requesting runtime permissions and are now required to target an API greater than 22.

Target SDK for other apps was raised to the minimum SDK which is 28.
@tkirshboim tkirshboim marked this pull request as ready for review June 15, 2023 19:49
@tkirshboim tkirshboim requested a review from joebowbeer June 15, 2023 19:49
Copy link
Contributor

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkirshboim tkirshboim merged commit f52051e into libpd:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent
2 participants