Give up com.noisepages.nettoyeur:midi and reimplement Midi #129
+221
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplement Midi adapters using Android Midi API, reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/
Closed
Contributor
Author
|
Converted to draft, as needing more documentation, and also it should support multiple Midi devices (channel > 15). |
Contributor
Author
|
I think it's ready for service now. |
joebowbeer
pushed a commit
that referenced
this pull request
Jul 4, 2025
* Give up com.noisepages.nettoyeur:midi Reimplement Midi adapters using Android Midi API, reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/ * Midi adapters: handle multiple devices, and javadoc-ument code
Contributor
|
Moved to #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/