-
Notifications
You must be signed in to change notification settings - Fork 93
Updates on midi and build system #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reimplement Midi adapters using Android Midi API, reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/
AGP 8.11.0 gradle 8.13 buildToolsVersion 35.0.0 ndk 27.2.12479018
this allows to make apps independent from PdCore sources, so they can declare pd-core dependency like a maven one.
…ite' style dependency
|
Fixes #157 ? |
…ign to 16KB pagesize, as required by google
|
Not yet integrated into the repo? |
joebowbeer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Ant1r !
I made a few tweaks to:
- address some deprecation warnings
- normalize style
- update dependencies
|
The default branch now builds and creates an aar artifact. The publishToSonatype (staging) step is currently failing: Migration docs: |
are the credentials in Settings/Security/Secrets and variables/Action still valid for the sonatype account? |
|
The I think the changes consist of:
|
|
See #158 |
This PR includes:
com.noisepages.nettoyeur:midi) and other fixesThe latter allows to fix the CI build, as well as long standing issues about adding native code externals to Pd in Android apps.
Here is a quick description of the changes:
This has the benefit that now, pd-core dependency is declared by the apps the same way as if they were standalone; so they can safely be taken as examples.
Note: 2 small issues remain:
prefab, not only the needed.hfiles. This could be fixed with copying the only needed files to a temporaryinclude/dir before building.Anyway this issue doesn't harm much, because final apps don't include the prefab dir.
1.3.0for now, to be discussed) is present at 2 distinct places:build.gradleandPdCore/build.gradle, and both need to be kept in sync.I couldn't find a way to merge them both.
Fixes #127.
Fixes #157.
Closes #75.