Oboe support #167
Oboe support #167
Conversation
joebowbeer
left a comment
joebowbeer
left a comment
There was a problem hiding this comment.
Next steps?
Bump version and create a snapshot?
CircleOfFifths/src/org/puredata/android/fifths/CircleOfFifths.java
Outdated
Show resolved
Hide resolved
Ant1r
force-pushed
the
oboe2
branch
3 times, most recently
from
b186be3 to
0eec5a0
Compare
PdCore/pd-core/src/main/java/org/puredata/android/io/PdAudio.java
Outdated
Show resolved
Hide resolved
PdCore/pd-core/src/main/java/org/puredata/android/io/PdAudio.java
Outdated
Show resolved
Hide resolved
|
Can you bump the version in this PR to preserve the 1.3.0 snapshot? 1.4.0 or 2.0.0 |
- add MODIFY_AUDIO_SETTINGS permission, which oboe needs to give best results - add "APP_STL := c++_shared" to Application.mk when the app needs native compilation
done! |
|
note: the CI build seems caused by a server error: Error: Exception in thread "main" java.io.IOException: Server returned HTTP response code: 504 for URL: https://github.com/gradle/gradle-distributions/releases/download/v8.13.0/gradle-8.13-bin.zipI cannot run it again, but I think admins can. |
|
I can confirm it builds fine on my fork's CI (it fails actually, but only because of missing sonatype credentials). |
|
@joebowbeer plz rerun CI |
joebowbeer
left a comment
joebowbeer
left a comment
There was a problem hiding this comment.
LGTM
Is this ready to merge? Or should libpd be merged first?
|
I think you can merge. Git's magic allows to use any 'branch' of a submodule, even a not-yet-merged PR! I think it will be merged eventually. |
|
Depends on this commit: libpd/libpd#422 (2ed8b39ba0a82c27b9da087dac01d8e5ff55ee85) |
2 participants
This PR updates the libpd submodule, to include the (currently discussed) oboe branch.
It also adds selection of the audio input and output devices from the preferences screen.
Should fix #47, fix #66, fix #89.