Skip to content

Conversation

@Ant1r
Copy link
Contributor

@Ant1r Ant1r commented Jan 5, 2026

This moves the libpd HEAD to the new libpd/libpd#423 proposal for supporting Oboe, which replaces libpd/libpd#422.

It implies a small change in PdAudio, replacing the abandoned setRecordingDeviceId() and setPlaybackDeviceId() PdBase's methods with the options argument of PdBase.openAudio().

@danomatika
Copy link
Member

@Ant1r Do you want to be in the libpd/Android group so you can manage this directly? I haven't done any Android dev so it would be great to increase the maintenance team. What do you think @joebowbeer?

@Ant1r
Copy link
Contributor Author

Ant1r commented Jan 7, 2026

be in the libpd/Android group

there's something reassuring about being forced to be reviewed :-)
but if @joebowbeer thinks it could help, I'd be honored.

@joebowbeer
Copy link
Contributor

@danomatika if by "managing this directly" you mean bypassing PR approvals and overriding branch protection, I do not want to endorse that.

I and @tkirshboim do appreciate what @Ant1r is doing and we can use more help. I'll confer with Tal just to make sure.

I hope we can release the new Oboe support to maven central soon.

Copy link
Contributor

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - when to merge?

@Ant1r
Copy link
Contributor Author

Ant1r commented Jan 7, 2026

when to merge

I think it can be merged. Maybe it would need a version bump?

@joebowbeer
Copy link
Contributor

I'll merge now unless you want to preserve the 1.4.1-SNAPSHOT. Ok?

@Ant1r
Copy link
Contributor Author

Ant1r commented Jan 7, 2026

ok fine!

@joebowbeer joebowbeer merged commit 98a2630 into libpd:master Jan 7, 2026
1 check passed
@tkirshboim
Copy link
Member

I and @tkirshboim do appreciate what @Ant1r is doing and we can use more help. I'll confer with Tal just to make sure.

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants