Reign in the nuking of wireless interfaces - #1234
Open
rah2501 wants to merge 1 commit into
Open
Conversation
rah2501
marked this pull request as draft
January 3, 2026 12:27
rah2501
force-pushed
the
wireless-reign-in
branch
3 times, most recently
from
June 17, 2026 07:59
28347c4 to
7599866
Compare
Don't nuke all the wireless interfaces, just the interfaces that LibreMesh itself creates. Except for the OpenWrt-generated default interfaces, which are disabled.
rah2501
force-pushed
the
wireless-reign-in
branch
from
June 23, 2026 12:05
7599866 to
597b84c
Compare
rah2501
marked this pull request as ready for review
June 23, 2026 12:05
Member
|
@rah2501 are you sure keeping the default interface disabled but around doesn't create any problem? The nuking was most probably due to historical quirks, with disabled things remaining around. |
Author
It's not possible for any person to be 100% sure of such a thing. Certainly it hasn't created any problems for me and I can't envision how it would create a problem for others. |
Member
|
Testing it on the hardware you have at hands seems good enough to me |
G10h4ck
requested changes
Jul 23, 2026
G10h4ck
approved these changes
Jul 25, 2026
G10h4ck
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't nuke all the wireless interfaces, just the interfaces that LibreMesh itself creates. Except for the OpenWrt-generated default interfaces, which are disabled.