Fix: Add missing feature for with-avahi feature
#1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a missing dependency for the with-avahi feature by adding the required futures-util/async-await-macro feature flag.
- Adds the missing
futures-util/async-await-macrofeature dependency to thewith-avahifeature configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Thanks for the quick fix. Would it be useful to prevent regression in the CI? |
Member
Author
|
Would probably help here yeah. But I will do that tomorrow then. |
|
This issue affects the build of Raspotify. |
Member
Author
|
Good reminder, will try to see it done with the next release^^ |
Prevents regression of missing feature dependencies in discovery backends (with-avahi, with-dns-sd, with-libmdns). This check ensures all feature combinations compile correctly on Linux where the native dependencies are available.
Member
I'm pushing the check to your repo hoping to merge this one also. |
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1598