fix: connection issues after system suspend on Linux #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Instant::now()` for `is_expired` doesn't account for time spent suspended on Linux as it internally uses `CLOCK_MONOTONIC`. Using `SystemTime::now()` instead (adjusting `timestamp` to `SystemTime` accordingly) fixes this. Although `SystemTime` could go backwards (e.g. due to NTP updates), expiration deals with external systems and thus this should be a non-local time anyhow. Fixes librespot-org#1617
Member
|
Thanks! |
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Instant::now()foris_expireddoesn't account for time spent suspended on Linux as it internally usesCLOCK_MONOTONIC. UsingSystemTime::now()instead (adjustingtimestamptoSystemTimeaccordingly) fixes this.Although
SystemTimecould go backwards (e.g. due to NTP updates), expiration deals with external systems and thus this should be a non-local time anyhow.Fixes #1617