-
Notifications
You must be signed in to change notification settings - Fork 790
CI: Create a PR for the release preparations #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Create a PR for the release preparations #1631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the release preparation workflow to use a pull request-based review process instead of direct commits. This change enables code review of automated version bump changes before they are merged.
- Replaced direct commit action with PR creation action
- Added
pull-requests: writepermission to enable PR creation - Removed conditional execution check for ACT (local testing tool)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Oh right, reminder for myself that we need to allow actions to create PR's in the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
I would have liked to have the automated changes directly committed without any interactions, but as the committer is the github-action bot and not the actor itself, we would need to give the bot bypass access (which is besides the point that it's not possible because of the following reason). Which in return would mean, anyone could bypass the protection of the branches. Which might probably a bad idea.
That's why we are sorta forced creating a PR for the automated changes. I will stop here for now as it's pretty late and will continue tomorrow.