Skip to content

Conversation

@photovoltex
Copy link
Member

I would have liked to have the automated changes directly committed without any interactions, but as the committer is the github-action bot and not the actor itself, we would need to give the bot bypass access (which is besides the point that it's not possible because of the following reason). Which in return would mean, anyone could bypass the protection of the branches. Which might probably a bad idea.

That's why we are sorta forced creating a PR for the automated changes. I will stop here for now as it's pretty late and will continue tomorrow.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release preparation workflow to use a pull request-based review process instead of direct commits. This change enables code review of automated version bump changes before they are merged.

  • Replaced direct commit action with PR creation action
  • Added pull-requests: write permission to enable PR creation
  • Removed conditional execution check for ACT (local testing tool)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@photovoltex
Copy link
Member Author

Oh right, reminder for myself that we need to allow actions to create PR's in the settings.

@photovoltex photovoltex requested a review from Copilot November 10, 2025 16:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@photovoltex photovoltex merged commit b20316f into librespot-org:dev Nov 10, 2025
12 checks passed
@photovoltex photovoltex deleted the ci/adjust-to-ruleset-restrictions branch November 14, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant