Make SpotifyId base62 / base16 methods infallible #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only error case is a non-utf8 string, which is impossible since we're building it from a fixed alphabet. This allows removing a bunch of unnecessary error handling branches.
photovoltex
reviewed
Nov 12, 2025
Member
There was a problem hiding this comment.
Wanted to asked about the
write!().unwrap()call infile_id.rs, but as it turns out some searching and understanding gives the answer.fmt::Write for String never returns an error itself
Seems like a reasonable change. Please add a changelog entry to give this the final touch, then we could probably merge this.
photovoltex
requested changes
Nov 13, 2025
wfraser
force-pushed
the
spotify-id-base62-infallible
branch
from
361a09d to
f2e80f0
Compare
photovoltex
approved these changes
Nov 13, 2025
Member
|
Thanks for the change :) |
Member
|
Just found out that |
Contributor
Author
|
Oh, nice find, I can do a quick PR for that too. |
Member
|
If you want to, go for it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both of these, the only error case is a non-utf8 string, which is impossible since we're building it from a fixed alphabet.
This allows removing a bunch of unnecessary error handling branches.
Also, for base16, there's no need to implement parsing/formatting, just use the stdlib's hex conversion/formatting code.