Proposed workflow to auto check PRs #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing automatic image reqts checking
|
Seems good to me. Is there anything else you think we should be checking as part of this? Overall, I think it'd help out. Perhaps prior to getting it across the other repos, keep it here for a bit to allow some time to see if we want to adapt it a bit. |
|
Works for me. I only added those checks as thats what i can see as the reqts listed in the guidelines. I thought about trying to find dupes or 'very similar' images somehow, but thats not included in this current workflow. I couldn't find an obvious and easy way to make that work without importing a larger library of some kind. This current worklow just uses straight ubuntu-latest and thats it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed gh action to automatically check PRs for:
If this workflow is acceptable, then I can commit to each thumbnail repo. Note that usage of this action falls under my free use of gh actions, but not sure if it would for the libretro-thumbnail org.