Skip to content

Support for newer glslang versions without SPIRV and HLSL libraries #17563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keithbowes
Copy link
Contributor

Description

This makes it so that RetroArch can be compiled with glslang 14+, which have removed the separate HLSL library. Currently, the SPIRV library is an empty stub in glslang 14/15 but the indicated plan is to eventually remove that too, so I've followed suit.

Related Issues

Fixes #16571

@LibretroAdmin
Copy link
Contributor

I'm kinda wary of this. Will this have any impact for the D3D drivers when using Slang shaders?

@keithbowes
Copy link
Contributor Author

No idea, but I was just checking back now that glslang 15.2.0 has been released with SPIRV removed. I had to recompile RetroArch because it complained that it couldn't find libSPIRV.so.15. I'm on a new computer and so would have to install MinGW stuff in order to test in Windows, but I don't see why it wouldn't work; the HLSL and SPIRV functionality is still there, but in the glslang library instead of in separate libraries. With this PR, the configure script still checks for those libraries and uses them if the system has them, but if the system doesn't, it doesn't produce an error (similarly to what happened with OSDependent and OGLCompiler when they were removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream GLSLang releases no longer detected by QuickBuild
2 participants