Skip to content

Libnx enable cloudsync #17708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

lucascanero
Copy link
Contributor

Guidelines

  1. Rebase before opening a pull request
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises

Description

[Description of the pull request, detail any issues you are fixing or any features you are implementing]

Related Issues

[Any issues this pull request may be addressing]

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

Reviewers

[If possible @mention all the people that should review your pull request]

@lucascanero lucascanero marked this pull request as draft March 17, 2025 20:07
@lucascanero lucascanero marked this pull request as ready for review March 17, 2025 20:10
char* urlcopy = (char*)malloc(domain_len + path_len + 2);
if (!urlcopy) {
fprintf(stderr, "Memory allocation failed for urlcopy\n");
return NULL; // Handle the error appropriately
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also perhaps better to use ANSI-C comments as in the rest of the code

@lucascanero lucascanero marked this pull request as draft March 17, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants