Add core option to select additional msx scc/scc-i sound card #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylverb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SCC-I (=SCC+) sound card has been hardcoded in some generic machines config files to force the presence of this SCC+ sound card. It's not a proper way to do it for several reasons (limited to some machines config, not possible to remove it easily, not possible to choose SCC sound card added, ...).
This PR is fixing this by adding a core option to select a SCC/SCC-I sound card type to add to the system.
It is also fixing a bug in savestate loading when SCC is in "real" mode.
It is allowing to run disks games needing SCC/SCC-I sound cartridge to run correctly (original version of Snatcher/SD-Snatcher are not starting if correct sound cartridge is not present, and some Konami Game Collection disks are offering SCC/SCC-I versions of some games if sound cartridge is present)