Fix FPS Counter when Frame Skipping is on #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frame skipping options were making no difference to FPS reported, this was due to video_run being called regardless of whether skip_next_frame had been set.
|
I think this is on purpose. Check the video_run function, you will see how we purposely re-submit the previous frame when skip_next_frame is true. So yeah it depends on what you consider a frame. It is running at "60fps" but some frames are repeated :D I am not sure whether this is a good idea or not, I might ask around someone who knows :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frame skipping options were making no difference to FPS reported, this was due to video_run being called regardless of whether skip_next_frame had been set.