ci: build the aarch64 core in the aarch64 image - #22
Merged
Conversation
The Linux aarch64 job inherited the x64 job's image override, so it ran the amd64 image on the aarch64 runner and shipped an x86-64 hbmame_libretro.so in the aarch64 nightly (libretro/libretro-super#2077). Dropping the override lets linux-aarch64.yml's own image apply; it provides /usr/bin/gcc-12, so the OVERRIDE_CC/OVERRIDE_CXX pair keeps working unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes libretro/libretro-super#2077:
hbmame_libretro.soin the Linux aarch64 nightly is an x86-64 binary.My aarch64 job in #13 mirrored the x64 job a little too closely and kept its
image:line, so the job ran the amd64 image on the aarch64 runner and produced an amd64 core. Dropping that one line lets the image fromlinux-aarch64.ymlapply. That image installsgcc-12andgcc-14at/usr/bin/gcc-12etc. and defaultsgccto 12, soOVERRIDE_CC/OVERRIDE_CXXstill resolve and the job keeps building with the same compiler as x64.Sorry for the breakage — #13 was the one aarch64 PR I could not build locally (this machine OOMs on hbmame), and this is exactly the kind of thing that slipped through as a result.