ci: turn the macOS x64 job back on - #23
Merged
Merged
Conversation
It builds. The job and its include have been commented out; nothing else in the file changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libretro-build-osx-x64and its include are commented out. I built that target on a GitHub runner and it produced a core, so this turns the job and the include back on and changes nothing else.While I was in here: two things about the Android side
Not part of this PR, but worth writing down somewhere.
android-x86andandroid-x64have no libretro OSD path.makefilegivesandroid-armandandroid-arm64each anifeq ($(OSD), retro)branch — the "RETRO HACK no sdl for libretro android" one that calls GENie with--osd=retro --NO_OPENGL=1. The two x86 targets only have the SDL variant, so a build for them goes downPROJECTDIR_SDLand stops in GENie:That is presumably why
android-x86_64is commented out too. I tried giving those two targets the same retro branch the ARM ones have; it does get past GENie — the target becomesbuild/projects/retro/hbmame/gmake-android-x64/Makefile— but the build then still stops about thirty seconds in, during the generation phase, and I have not pinned that one down. Happy to send the patch if it is useful as a starting point, but I did not want to propose a fix I cannot show working.The green
android-arm64-v8ajob is not building from scratch. In the last pipeline it finishes in 83 seconds, whereosx-arm64takes 1513s andwindows-x641243s. It does produce an artifact —hbmame_libretro_android.so.zipis in the nightlies — so it is running from the CI cache with the project makefiles already generated, which means the GENie step above never runs. If that cache is ever lost, that job will hit the same wall the x86 ones do today, sinceREGENIE=0will no longer have anything to reuse.