Unify makefiles #44
Open
Unify makefiles #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi there @keithbowes , sorry for the late reply. I'd still be interested in merging this now at long last, only issue is we have a merge conflict. If you could merge this, I will promise you this will be merged as soon as possible. My apologies for the long wait. |
keithbowes
force-pushed
the
unify-makefiles
branch
from
9f6fbf2 to
3830460
Compare
Author
|
I understand what you mean about taking a long time to read messages, @twinaphex . Though, for me, it's due to anxiety, which might not be the case for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some experimenting with setting up a translation framework, I noticed that the non-ASCII characters in translations weren't showing correctly, so I went ahead and tried the Cairo version, in which not only did the non-ASCII characters show correctly but also the font was much better. Anyway, I noticed that the Makefile for the Cairo build hadn't been updated in years and had some legacy cruft, so I decided to unify the Makefiles: renaming Makefile to Makefile.cairo, removing everything but what's specifically needed for Cairo builds, and making minor changes in Makefile.libretro and Makefile.common. Now, Makefile.libretro still makes a non-Cairo build by default, but if you want a Cairo build, you just need to set
WANT_CAIRO.