Fix ParaLLEl-RDP interlaced Bob output and add Bob - Sharp / Blend modes#637
Open
Immersion95 wants to merge 1 commit into
Open
Fix ParaLLEl-RDP interlaced Bob output and add Bob - Sharp / Blend modes#637Immersion95 wants to merge 1 commit into
Immersion95 wants to merge 1 commit into
Conversation
Add a cleaner ParaLLEl-RDP deinterlacing selection with Bob, Bob - Sharp, Blend, and Weave modes. Bob keeps the existing field-offset behavior with linear filtering. Bob - Sharp uses the same field-offset logic with nearest filtering for a sharper result at higher internal resolutions. Blend adds a softer field-blending option. Weave keeps the existing weave-style behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the ParaLLEl-RDP Bob deinterlacing path by making Bob explicitly run as a final deinterlacing pass when the VI is in serrate/interlaced mode, instead of relying on the previous final-pass/downscale path where the pass could be skipped or applied inconsistently.
The corrected
Bobmode now applies the field offset consistently to produce a stable progressive output from interlaced fields. This PR also addsBob - Sharp, which uses the same corrected Bob path but switches to nearest filtering to avoid vertical line blending at higher internal resolutions.A
Blendmode is also added as a softer deinterlacing option alongsideWeave.Modes
Bob: corrected field-offset Bob deinterlacing.Bob - Sharp: corrected Bob path with nearest filtering for a sharper result at higher internal resolutions.Blend: softer field-blending deinterlacing option.Weave: existing weave-style behavior.This patch was prepared with AI assistance, so if maintainers prefer a different implementation, naming, or structure, I am completely fine with it being adjusted or rewritten.
Still, the result is much more stable than the default Bob deinterlacing, especially at higher resolution.
You can find builds here : https://github.com/Immersion95/mupen64plus-libretro-nx/actions/runs/27217496700