Basic disk control and M3U support#211
Conversation
|
Will take a look. Thanks. |
There was a problem hiding this comment.
Not a fan of the change in style in a feature change.
There was a problem hiding this comment.
do you mean the brace style, and the return value and static qualifier being on a separate line?
There was a problem hiding this comment.
Could you check again please?
There was a problem hiding this comment.
Could you just squash all the commits you've made?
| static struct retro_disk_control_callback retro_disk_control_cb; | ||
| static struct retro_disk_control_ext_callback retro_disk_control_ext_cb; | ||
|
|
||
| static bool read_m3u(const char *file) |
There was a problem hiding this comment.
There isn't a generic m3u reader that could be used? Is this code picked up from another core?
| { | ||
| char line[PATH_MAX]; | ||
| char name[PATH_MAX]; | ||
| FILE *f = fopen(file, "r"); |
There was a problem hiding this comment.
Should probably be using libretro functions if you can.
| // disk swapping | ||
| #define M3U_MAX_FILE 4 | ||
|
|
||
| static char disk_paths[M3U_MAX_FILE][PATH_MAX_LENGTH]; |
There was a problem hiding this comment.
The CD stuff needs to be moved over but the g_CAPS syntax is generally used for globals.
There was a problem hiding this comment.
Could you just squash all the commits you've made?
dszakallas
force-pushed
the
naive-disk-control
branch
3 times, most recently
from
e1ae1e1 to
ca9473d
Compare
| int rv; | ||
|
|
||
| game_info_path_save(info_); | ||
| extract_basename(g_GAME_NAME, info_->path, sizeof(g_GAME_NAME)); |
There was a problem hiding this comment.
The name here is misleading? It's the path. Also... can't info be NULL? Opera allows starting without a game.
dszakallas
force-pushed
the
naive-disk-control
branch
from
383e5b4 to
6036d5b
Compare
2 participants
This PR upgrades libretro header to a newer version that has extended disk tray interface and implements the disk tray control callbacks required for swapping disks.
Eject does nothing, insert saves the nvram, resets the emulation, loads the image and finally the nvram.
The purpose of this PR is to provide convenience functionality of swapping disks from inside retroarch, and m3u support, not faithful emulation of disk control of the hardware.