Skip to content

Add binding to field 340 conversion #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add binding to field 340 conversion #1216

merged 1 commit into from
Feb 28, 2023

Conversation

klngwll
Copy link
Contributor

@klngwll klngwll commented Feb 21, 2023 •
edited
Loading

Add binding to 340$l as per LC convspec 2.3 and MARC -> https://www.loc.gov/marc/bibliographic/bd340.html

@klngwll klngwll marked this pull request as ready for review February 22, 2023 14:20
niklasl
niklasl approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klngwll klngwll merged commit b4cb774 into develop Feb 28, 2023
@klngwll klngwll deleted the feature/binding branch February 28, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasl niklasl niklasl approved these changes

@kwahlin kwahlin Awaiting requested review from kwahlin

@andand79 andand79 Awaiting requested review from andand79

@olovy olovy Awaiting requested review from olovy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klngwll @niklasl