Add representation of search results as Atom feeds #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasl
force-pushed
the
feature/change-feeds
branch
2 times, most recently
from
fdbb435 to
d8ad065
Compare
olovy
approved these changes
Aug 16, 2023
Contributor
olovy
left a comment
olovy
left a comment
There was a problem hiding this comment.
LGTM!
We can adjust the content format later.
Comment on lines
267
to
273
| if (!(request.getContentType() in [MimeTypes.JSON, MimeTypes.JSONLD])) { | ||
| data[JsonLd.CONTEXT_KEY] = contextData | ||
| if ((request.getContentType() in [MimeTypes.ATOM])) { | ||
| var feedId = getFeedId(data, uri) | ||
| return searchFeed.represent(feedId, data) | ||
| } | ||
| return converterUtils.convert(data, uri, request.getContentType()) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!(request.getContentType() in [MimeTypes.JSON, MimeTypes.JSONLD])) { | |
| data[JsonLd.CONTEXT_KEY] = contextData | |
| if ((request.getContentType() in [MimeTypes.ATOM])) { | |
| var feedId = getFeedId(data, uri) | |
| return searchFeed.represent(feedId, data) | |
| } | |
| return converterUtils.convert(data, uri, request.getContentType()) | |
| if ((request.getContentType() in [MimeTypes.ATOM])) { | |
| data[JsonLd.CONTEXT_KEY] = contextData | |
| var feedId = getFeedId(data, uri) | |
| return searchFeed.represent(feedId, data) | |
| } | |
| else if (!(request.getContentType() in [MimeTypes.JSON, MimeTypes.JSONLD])) { | |
| data[JsonLd.CONTEXT_KEY] = contextData | |
| return converterUtils.convert(data, uri, request.getContentType()) |
niklasl
force-pushed
the
feature/change-feeds
branch
from
518e445 to
3c9584a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.