Add functionality for sorting facets/observations into a tree #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This might be a too naive approach to how this should work? Hopefully it can be a start... |
kwahlin
requested changes
Jan 8, 2025
| SearchUtils2(Whelk whelk) { | ||
| this.queryUtil = new QueryUtil(whelk); | ||
| this.disambiguate = new Disambiguate(whelk); | ||
| this.jsonLd = whelk.getJsonld(); |
Contributor
There was a problem hiding this comment.
No need to pass on the JsonLd object, use Disambiguate.isSubclassOf() instead.
| var sliceNode = new LinkedHashMap<>(); | ||
| var isRange = rangeProps.contains(property); | ||
| var observations = getObservations(buckets, isRange ? queryTree.removeTopLevelPropValueWithRangeIfPropEquals(property) : queryTree, nonQueryParams); | ||
| if (property.name().equals(Disambiguate.RDF_TYPE)) { |
Contributor
There was a problem hiding this comment.
Use property.isType() to catch both work and instance types (hasInstanceType/instanceOfType in addition to rdf:type).
lrosenstrom
force-pushed
the
feature/lws-268-facettree
branch
from
78992be to
7d4befb
Compare
kwahlin
approved these changes
Jan 16, 2025
kwahlin
reviewed
Jan 16, 2025
| var children = findChildren(observation, observations); | ||
| if (!children.isEmpty()) { | ||
| queue.addAll(children); | ||
| observation.put("children", children); |
Contributor
There was a problem hiding this comment.
Suggested change
| observation.put("children", children); | |
| observation.put("_children", children); |
Since children is not a defined property
lrosenstrom
force-pushed
the
feature/lws-268-facettree
branch
from
ff9f414 to
4994254
Compare
lrosenstrom
force-pushed
the
feature/lws-268-facettree
branch
2 times, most recently
from
54965fa to
12e974a
Compare
This reverts commit c15d179.
…g multiple roots from different levels in the tree.
lrosenstrom
force-pushed
the
feature/lws-268-facettree
branch
from
1c5dee1 to
f55b89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we can try this out on dev2 to see how it works in practice.