Skip to content

feat(lxl-web): Add category property to display-web #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

johanbissemattsson
Copy link
Contributor

Description

Solves

Adds category property to display-web.json

Summary of changes

  • Adds category property to display-web

Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think alternateProperties is necessary.

Note that category is experimental at this point. Even if it replaces genreForm, we want to see if something is off (and if it does replace it, genreForm will be gone; so there is probably no case where alternateProperties would be needed for these two?

@johanbissemattsson
Copy link
Contributor Author

I don't think alternateProperties is necessary.

Note that category is experimental at this point. Even if it replaces genreForm, we want to see if something is off (and if it does replace it, genreForm will be gone; so there is probably no case where alternateProperties would be needed for these two?

👍 alternateProperties is now removed in 82d2b79 .

My intention adding it was so category can easily be tested depending on the used enviroment (e.g. if category exists on the DEV but not QA) but if it still is very experimental then it's probably better to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants