Canvas size fixes in Emscripten mode #14690
Open
+7
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the old code, we tried to detect whether the canvas size was controlled with css by setting the canvas size to 1, then using
emscripten_set_element_css_sizeto see if anything changed.I suggest we leave the canvas size alone, except when the
SDL_WINDOW_FILL_DOCUMENTflag is set. This means the canvas doesn't unexpectedly mutate (or its css). Also, on destroy, it's best just to clean up and not to mutate the canvas.Finally, when
SDL_WINDOW_HIGH_PIXEL_DENSITYexists, work backwards from the canvas size. For example:This is intuitive because the canvas is setting the precedent for the window size, instead of SDL trying to guess by peering into the css.