Skip to content

Fix compile error in MSVC 19.29 #15133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madebr merged 1 commit into from
Feb 28, 2026
Merged

Fix compile error in MSVC 19.29 #15133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/testvulkan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ static void createInstance(void)
int count_extensions = count_instance_extensions + 1;
instanceExtensions = SDL_malloc(count_extensions * sizeof(const char *));
instanceExtensions[0] = VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME;
SDL_memcpy(&instanceExtensions[1], instance_extensions, count_instance_extensions * sizeof(const char*));
SDL_memcpy((char **) &instanceExtensions[1], instance_extensions, count_instance_extensions * sizeof(const char*));

instanceCreateInfo.enabledExtensionCount = count_extensions;
instanceCreateInfo.ppEnabledExtensionNames = instanceExtensions;
Expand All @@ -283,7 +283,7 @@ static void createInstance(void)
result = vkCreateInstance(&instanceCreateInfo, NULL, &vulkanContext->instance);

if (instanceExtensions != NULL) {
SDL_free(instanceExtensions);
SDL_free((char **) instanceExtensions);
}

if (result != VK_SUCCESS) {
Expand Down Expand Up @@ -500,9 +500,9 @@ static void createDevice(void)
VkDeviceCreateInfo deviceCreateInfo = { 0 };
static const char *const deviceExtensionNames[] = {
VK_KHR_SWAPCHAIN_EXTENSION_NAME,
#ifdef __APPLE__
#ifdef __APPLE__
"VK_KHR_portability_subset"
#endif
#endif
};
VkResult result;

Expand Down
Loading