Skip to content

Fix potential memory leak in SDL_HIDAPI_HapticOpenFromJoystick() on error #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slouken merged 1 commit into from
Mar 1, 2026
Merged

Fix potential memory leak in SDL_HIDAPI_HapticOpenFromJoystick() on error #15140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/haptic/hidapi/SDL_hidapihaptic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ bool SDL_HIDAPI_HapticOpenFromJoystick(SDL_Haptic *haptic, SDL_Joystick *joystic
haptic->neffects = device->driver->NumEffects(device);
haptic->effects = (struct haptic_effect *)SDL_malloc(sizeof(struct haptic_effect) * haptic->neffects);
if (haptic->effects == NULL) {
SDL_free(list_node);
device->driver->Close(device);
SDL_free(device);
return SDL_OutOfMemory();
Expand Down
Loading