Deal with sensors on ps4/5 guitars#15143
Merged
Merged
Conversation
sanjay900
changed the title
sanjay900
marked this pull request as draft
March 2, 2026 04:09
sanjay900
force-pushed
the
wii-ps3-instruments
branch
from
March 2, 2026 06:28
fcf1bce to
cd8f10f
Compare
sanjay900
marked this pull request as ready for review
March 7, 2026 21:45
sanjay900
marked this pull request as draft
March 8, 2026 00:32
sanjay900
marked this pull request as ready for review
March 8, 2026 00:38
slouken
reviewed
Mar 8, 2026
| SDL_PrivateJoystickAddSensor(ctx->joystick, SDL_SENSOR_ACCEL, (float)(1000 / ctx->report_interval)); | ||
| } | ||
|
|
||
| if (ctx->guitar_tilt_supported) { |
Collaborator
There was a problem hiding this comment.
I'm still not comfortable with these coming through as sensor data, but I'll accept this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for whammy and tilt on PS4/5 guitars
PS4/5 controllers put device specific data into a specific region in the report, so we have to extract it sperately.
No known guitars use the right stick on the guitar, so to keep things working similarly to PS3, i have opted to map whammy and tilt the same way as the PS3 rb guitars.
Also noted there was an off by one with tilt on PS3 guitars while testing this, and it turns out in some scenarios that actually matters
Existing Issue(s)