stdinc: On Windows, uppercase the system environment table's var names.#15976
Open
icculus wants to merge 1 commit into
Open
stdinc: On Windows, uppercase the system environment table's var names.#15976icculus wants to merge 1 commit into
icculus wants to merge 1 commit into
Conversation
icculus
force-pushed
the
sdl3-windows-envvars-uppercased
branch
from
July 12, 2026 03:58
9b10c08 to
895afe5
Compare
Collaborator
Author
|
This is failing tests on Windows now, because: Naturally, this is no longer lowercased on Windows when the child process get access to it. Test needs to get fixed. |
icculus
force-pushed
the
sdl3-windows-envvars-uppercased
branch
2 times, most recently
from
July 12, 2026 14:38
9d8ad1e to
3842d89
Compare
icculus
force-pushed
the
sdl3-windows-envvars-uppercased
branch
from
July 12, 2026 15:02
3842d89 to
f5cf5fb
Compare
icculus
marked this pull request as ready for review
July 13, 2026 22:42
Collaborator
Author
|
Test got fixed, this can merge, if we are ready to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft because this hasn't been tested at all yet.testautomation banged on this, found an issue that was fixed, and now everything feels tested. :)Fixes #15086.