DOS: skip desktop mode restoration to fix crash when exiting on pure VGA#15984
Open
palxex wants to merge 1 commit into
Open
DOS: skip desktop mode restoration to fix crash when exiting on pure VGA#15984palxex wants to merge 1 commit into
palxex wants to merge 1 commit into
Conversation
slouken
reviewed
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash on DOS platforms when destroying a window on pure VGA hardware (e.g., IBM ISA VGA in 86box) that occurs 100%.
Testing Env: 86box with IBM ISA VGA, CWSDPMI r7, DJGPP v2.05, GCC 12.2.0.
Crash stack trace( SDL part only, symbolized):
During SDL_DestroyWindow, SDL_UpdateFullscreenMode is called with SDL_FULLSCREEN_OP_LEAVE. Inside it, there is a SDL_SetDisplayModeForDisplay(display, NULL) call explicitly commented as "Restore the desktop mode". On DOS, this operation is unnecessary during window destruction, and can cause a crash on pure VGA hardware. The actual return to text mode is already handled later in DOSVESA_VideoQuit.
This fix resolves the crash on pure VGA hardware and has been verified to cause no regression on VESA-compatible hardware.