test: Remove superfluous null byte from ps3_hid_report_descriptor#16010
Merged
Conversation
Remove a superfluous null byte at the end of ps3_hid_report_descriptor, as it might confuse some more stricter parser. The data in ps3_hid_report_descriptor probably comes for a libinput recording, and sometimes those can have superfluous null byte at the end. This is mentioned for example in the hidreport project: https://github.com/hidutils/hidreport/blob/64d40674038e8bb5e76c4191f5561ec1928c3c72/tools/libinput-recording-extract-hid-descriptor.py#L25-L27 As a proof that the original HID report descriptor of the actual device is 148 bytes long, the following lsusb capture can be compared: http://ps3.jim.sh/sixaxis/usb/lsusb.txt Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
Contributor
Author
|
cc @smcv |
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a superfluous null byte at the end of ps3_hid_report_descriptor, as it might confuse some more stricter parser.
Description
The data in ps3_hid_report_descriptor probably comes for a libinput recording, and sometimes those can have superfluous null byte at the end.
This is mentioned for example in the hidreport project: https://github.com/hidutils/hidreport/blob/64d40674038e8bb5e76c4191f5561ec1928c3c72/tools/libinput-recording-extract-hid-descriptor.py#L25-L27
As a proof that the original HID report descriptor of the actual device is 148 bytes long, the following lsusb capture can be compared: http://ps3.jim.sh/sixaxis/usb/lsusb.txt