Fix build on arm64ec.#16014
Merged
Merged
Conversation
Collaborator
|
What compiler are you using that sets |
Contributor
|
What are the errors you're seeing? I remember successfully building a arm64ec SDL3. |
Contributor
Author
llvm-mingw |
Contributor
Author
and later: |
Collaborator
|
The compiler is defining |
Contributor
Author
|
It is an odd choice, but it's consistent with how msvc does it (although they use _M_AMD64 and _M_ARM64EC). |
Collaborator
|
Yeah, this platform is native ARM64 and interprets x86_64 instructions. |
Collaborator
|
Well then this seems reasonable to merge...? |
sezero
approved these changes
Jul 21, 2026
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the build on arm64ec, which reports itself as x86_64 even though it's an arm architecture, by disabling code sections with x86_64 assembly on arm64ec.