wayland: guard null clipboard offer - #16256
Open
brahmkshatriya wants to merge 1 commit into
Open
Conversation
Contributor
|
Hmm, this fixes the issue on the surface, but there's still state that should be updated, even with a nil offer, that this would prevent. I think I have a better way to handle this. |
Author
|
Oh? what would that be? to update the clipboard state using the data device/seat even when the offer is nil? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Wayland selection callback can invoke
Wayland_DataOfferNotifyFromMIMEs(NULL, ...)when the compositor clears the clipboard selection. The function already handles a null offer while collecting MIME types, but subsequently passed that null pointer unconditionally toSetCurrentClipboardOffer(), which dereferences it.This caused a reproducible segmentation fault in the Wayland event pump:
Existing Issue(s)
No existing issue found for this specific null dereference.